Re: [PATCH] Preserve build IDs

[Lubomir Kundrak]

On Tue, 2008-04-15 at 15:04 -0400, Pavel Roskin wrote:
> On Tue, 2008-04-15 at 15:35 +0200, Robert Millan wrote:
> > On Tue, Apr 15, 2008 at 12:41:50AM +0200, Lubomir Kundrak wrote:
> > > This will make Fedora packagers have good sleep. I think we discussed
> > > this already on the list. Rationale behind disabling build-ids
> > > completely was that it caused images to grow a lot. Correct solution is
> > > to disable it from images only and let it exists in elf files for
> > > debugging purposes.
> > > 
> > > 2008-04-15  Lubomir Kundrak  <address@hidden>
> > > 
> > >   * aclocal.m4 (grub_PROG_OBJCOPY_ABSOLUTE): take only .text
> > >   section into account, newer toolchains generate unique build ids
> > >   * configure.ac: remove the test for --build-id=none acceptance,
> > >   we want build ids to bre preserved
> > >   * genmk.rb: add -R .note.gnu.build-id to objcopy, so build id
> > >   far from other sections don't cause the raw binary images grow
> > >   size
> > 
> > Looks good to me.  Pavel will probably know better though.
> 
> Looks good to me too.  There is a bug in objcopy if it's used without
> stripping the build ID.  But if we are stripping it, there should be no
> problem with it.

Actually that turned to not being a bug, if I recall correctly. It was
just that in plain flat binary files there's really no way to express
emptiness other by padding with zeroes.

However this is irrelevant since we no longer include that in the plain
binary files. There's little use of it anyways, as it would not be
possible to look it up in the file, given it resides in own section in
ELF, and plain binaries really have no sections.

Thanks,
-- 
Lubomir Kundrak (Red Hat Security Response Team)