Re: [PATCH] Workaround for the keyboard hang problem in intel mac

[Pavel Roskin]

On Wed, 2008-05-07 at 21:55 +0800, Bean wrote:

> +     /*
> +      * Due to a bug in apple's bootcamp implementation, INT 16/AH = 0 would
> +      * cause the machine to hang at the second keystroke. However, we can
> +      * work around this problem by ensuring the presence of keystroke with
> +      * INT 16/AH = 1 before calling INT 16/AH = 0.
> +      */

Can it be because interrupts are not enabled during the call?

> +     pushfw
> +     sti
...
> +     popfw

I would prefer explicit sti and cli without saving flags on the stack,
unless we want the code work with both enabled and disabled interrupts.

Robustness is not always handling unexpected situations.  Sometimes it's
enforcing the rules and being clear about it.

It's just a suggestion, not an invitation for a long discussion about
three instructions :-)

-- 
Regards,
Pavel Roskin