[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Please support installation on Xen virtual block devices

From: Pavel Roskin
Subject: Re: Please support installation on Xen virtual block devices
Date: Wed, 07 May 2008 13:33:15 -0400

On Wed, 2008-05-07 at 14:43 +0200, Robert Millan wrote:
> On Tue, May 06, 2008 at 05:33:23PM -0400, Pavel Roskin wrote:
> > On Tue, 2008-05-06 at 16:29 +0100, Ian Campbell wrote:
> > > Any comments on this patch?
> > 
> > It's basically OK, bug please provide the GNU style ChangeLog entry.
> > The second part of the patch doesn't need preprocessor conditionals
> > because it's already compiled for Linux only.  Please use tabs for
> > indentation rather than 8 spaces.  The innermost block is indented two
> > spaces too far.
> Ian, it looks like you copied this style from existing code.  Is that so?
> In that case, I don't think the indentation issue concerns your patch (if we
> have to fix indentation, we could just do it in the whole file).

Apparently, it was copied from the code that was inside an extra "for"
loop.  Anyway, it's a very minor issue, and I would just apply the patch
right now, but I prefer not to write changelog entries for others.

Pavel Roskin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]