[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Bug#478238: grub-probe: fails to find drive for /dev/sda10

From: Robert Millan
Subject: Re: Bug#478238: grub-probe: fails to find drive for /dev/sda10
Date: Mon, 12 May 2008 17:44:10 +0200
User-agent: Mutt/1.5.13 (2006-08-11)

On Sun, May 11, 2008 at 02:35:41PM +0300, Török Edwin wrote:
> /dev/sda9 is not a valid OpenBSD partition, and in partmap/pc.c:176 the
> iteration fails with an error: invalid disk label magic 0x%x.
> If I replace that return with a continue, it works.
> The problem is that grub2 stops looking for more partitions as soon as
> it encountered the invalid partition,

I think a correct fix for this belongs in grub_partition_iterate().  It should
only let its hook determine abortability rather than mandate that invalid
partitions should cause abortion.  Please, can you test the attached patch?

Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)

Attachment: partition_iterate.diff
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]