[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: backwards compatibility in grub.cfg

From: Christian Franke
Subject: Re: backwards compatibility in grub.cfg
Date: Fri, 30 May 2008 23:47:18 +0200
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv: Gecko/20071128 SeaMonkey/1.1.7

Robert Millan wrote:

diff -x configure -x -x CVS -x '*~' -x '*.mk' -urp 
../grub2/util/ ./util/
--- ../grub2/util/    2008-05-30 22:55:35.000000000 +0200
+++ ./util/   2008-05-30 23:16:53.000000000 +0200
@@ -116,10 +116,9 @@ prepare_grub_to_access_device ()
# If there's a filesystem UUID that GRUB is capable of identifiing, use it;
   # otherwise set root as per value in
+  echo "set root=`${grub_probe} --device ${device} --target=drive`"
   if fs_uuid="`grub-probe --device ${device} --target=fs_uuid 2> /dev/null`" ; 

Outside of the scope of the patch, but shouldn't '${grub_probe}' be used instead of 'grub-probe' in the rest of the script?

Same issue is in grub_probe is set but never used, so update-grub fails if /usr/sbin is not in PATH.

Christian Franke

reply via email to

[Prev in Thread] Current Thread [Next in Thread]