[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] register dummy drive

From: Robert Millan
Subject: Re: [PATCH] register dummy drive
Date: Wed, 4 Jun 2008 14:07:57 +0200
User-agent: Mutt/1.5.13 (2006-08-11)

On Tue, Jun 03, 2008 at 06:03:51PM -0400, Pavel Roskin wrote:
> > > > 
> > > > This patch solves the problem by spliting device/drive map[] entry 
> > > > registration
> > > > into a separate function, and using that from grub-probe.c to register 
> > > > a dummy
> > > > drive that will last during the current execution.
> > 
> > Part of what makes grub-probe interesting is that it shares a lot of code 
> > with
> > the freestanding GRUB you will run later, so when it is used during
> > grub-install & update-grub, it is very useful to catch possible problems.  I
> > think hostfs would defeat that purpose.
> Well, then we probably don't want to ignore any errors.  When do you
> have the situation that the drive cannot be resolved?

For example, when the next version of Linux decides to rename all devices (it
tends to do that often) and suddenly none of them match any entry.

The thing is, for what we're trying to do (-t fs, -t fs_uuid, -t partmap) we
don't care how will GRUB identify those devices when it's running on the BIOS,
so just any string that uniquely identifies them will be enough so we can
run our filesystem / partmap probes.

> My concern is that introducing a dummy object for non-testing purposes
> could indicate bad code quality.

It got a bit stuck anyway; see my other mail about -t partmap not working
with this method.

Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What good is a phone call… if you are unable to speak?
(as seen on /.)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]