[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] biosdisk / open_device() messing up offsets

From: Robert Millan
Subject: [PATCH] biosdisk / open_device() messing up offsets
Date: Thu, 5 Jun 2008 01:35:36 +0200
User-agent: Mutt/1.5.13 (2006-08-11)

It seems that open_device() in biosdisk is messing up offsets when
accessing partitions.  For example if you try:

grub> hexdump (hd0,1)

in grub-emu, you'll get a message saying lseek failed.  The problem is that
it substracts to the sector offset, so all accesses get to wrong data and
accessing sector 0 results in underflow.

I would think those lines (see patch) are plainly wrong, but they appear to
be very old, and it is strange that this wasn't noticed earlier.  Maybe we
have changed behaviour around partition/disk offsets, causing this breakage
without noticing?

Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What good is a phone call… if you are unable to speak?
(as seen on /.)

Attachment: partition.diff
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]