[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] missleading function name

From: Robert Millan
Subject: Re: [PATCH] missleading function name
Date: Thu, 5 Jun 2008 23:11:16 +0200
User-agent: Mutt/1.5.13 (2006-08-11)

On Wed, Jun 04, 2008 at 10:08:28PM -0400, Pavel Roskin wrote:
> On Thu, 2008-06-05 at 01:30 +0200, Robert Millan wrote:
> > IMHO the name of this function is highly misleading.  It makes one think
> > it just checks something, but it actually modifies our variables.  I think
> > "adjust" would fit better than "check".
> But nothing can be better that a good old-fashioned connect before the
> function.

What do you mean?

> It looks like it does several things:
> 1) it makes sectors disk relative from partition relative (I guess
> that's what grub-emu forgets)

Ah, that explains it.  Maybe the code in util/biosdisk.c comes from a time
in which kern/disk.c didn't do this.

Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What good is a phone call… if you are unable to speak?
(as seen on /.)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]