grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] disk/fs_uuid.c


From: Robert Millan
Subject: [PATCH] disk/fs_uuid.c
Date: Fri, 6 Jun 2008 18:23:39 +0200
User-agent: Mutt/1.5.13 (2006-08-11)

This disk driver allows access to partitions that contain a filesystem with
known UUID via "(UUID=xxxxxxx)" syntax.

The iterator is unimplemented on purpose, because it makes the code smaller
and it isn't useful to waste time inspecting the same devices twice while
scanning for LVM / whatsoever.

Also note that as it currently stands it is highly inefficient.  I can't
understand why;  new UUIDs are searched everytime on each open() call, but
this shouldn't be much of an issue since we have a disk cache in kernel to
make that efficient.  At least, it isn't e.g. for grub_fs_probe() which is
called multiple times.

Even with this efficiency problem, since it doesn't interfere with anything
else I'm inclined to commit it, if nobody objects.

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What good is a phone call… if you are unable to speak?
(as seen on /.)

Attachment: fs_uuid.diff
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]