[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] biosdisk / open_device() messing up offsets

From: Bean
Subject: Re: [PATCH] biosdisk / open_device() messing up offsets
Date: Sun, 8 Jun 2008 15:11:21 +0800

On Sun, Jun 8, 2008 at 2:52 PM, Pavel Roskin <address@hidden> wrote:
>> The reason I add device support for hexdump is to debug the nand
>> driver. I need to go around the disk cache and call the underlying
>> disk driver directly, so I use disk->dev->read. For (nand), there is
>> just one partition, so I didn't notice the problem then.
> Here's the patch.  Everything seems to be OK.  "--skip=N" is not
> recognized, but it's something in the option parsing code.  "-s N" is
> working.
> Please feel free to apply.

Perhaps we should keep the low level api, just fix the offset. Hexdump
is normally used for debugging, and the disk cache is quite annoying.

btw, please try the patch, it dumps the journal information. There
could be quite some output, you can use grub-fstest to capture it.


Attachment: e1.diff
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]