grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] biosdisk / open_device() messing up offsets


From: Pavel Roskin
Subject: Re: [PATCH] biosdisk / open_device() messing up offsets
Date: Thu, 12 Jun 2008 12:25:18 -0400

On Thu, 2008-06-12 at 17:51 +0800, Bean wrote:

> The call in grub_ext2_read_inode should be ok, blkoff would limit the
> read access to within a block.

You are right.  Now that we have grub_fshelp_read(), we don't need that
code, so I'm removing it.  The block normalization should be done in one
place.

> Seems fine to me.

Committed.

>  grub_ext3_get_journal still have some issue, but I
> can fix it after you commit it.

Please go ahead.  And please take care of reiserfs if you can.

-- 
Regards,
Pavel Roskin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]