[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] biosdisk / open_device() messing up offsets

From: Bean
Subject: Re: [PATCH] biosdisk / open_device() messing up offsets
Date: Fri, 13 Jun 2008 11:48:11 +0800

On Fri, Jun 13, 2008 at 12:25 AM, Pavel Roskin <address@hidden> wrote:
> On Thu, 2008-06-12 at 17:51 +0800, Bean wrote:
>> The call in grub_ext2_read_inode should be ok, blkoff would limit the
>> read access to within a block.
> You are right.  Now that we have grub_fshelp_read(), we don't need that
> code, so I'm removing it.  The block normalization should be done in one
> place.
>> Seems fine to me.
> Committed.
>>  grub_ext3_get_journal still have some issue, but I
>> can fix it after you commit it.
> Please go ahead.  And please take care of reiserfs if you can.


After more thoughts, I think the current method still have problem.
grub_disk_read reads up to 8192 bytes at a time, which can be larger
than the block size. Unless all or none of the sectors in the same
block is mapped, we end up reading the wrong sector. So we need to do
the mapping inside grub_disk_read.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]