[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Environment block support for grub2

From: Bean
Subject: Re: [PATCH] Environment block support for grub2
Date: Sun, 15 Jun 2008 03:22:41 +0800

On Sun, Jun 15, 2008 at 2:32 AM, Robert Millan <address@hidden> wrote:
> On Sat, Jun 14, 2008 at 11:41:18AM +0800, Bean wrote:
>> Hi,
>> No problem, I can find another name.
> Sorry, my mistake.  I complained about $root being inappropiate for early
> stage use, but after that I noticed that $root is used in every stage to
> refer to "whatever drive we're currently accessing";  even before $prefix
> is initialised!
> I'm fine with $root if nobody objects.
>> BTW, there are now two schemes for locating device at boot, the
>> environment block and robert's uuid device, which one do you favor, or
>> is there other scheme you prefer ?
> I think there's no problem with having two schemes as long as they don't
> take extra core.img space (except for the rare use cases they're intended
> to) and don't conflict with each other.

Yes, they can coexist easily. The environment block can overwrite root
variable, so to use uuid fs, just set the root variable, and to use
findroot, set uuid/lable/idfile.

> As for the "findroot" approach, I have two comments/ideas:
>  - Since findroot.mod is basicaly an heuristic, and it's possible we may
>    want different kinds of methods that work similarly, how about
>    calling it "findroot_by_file" or something like that?  Then we could
>    have a separate module for "findroot_by_uuid", etc.

Seems fine to me.

>  - I think your idea has the potential of obsoleting some parts of our
>    init routines, maybe (if we're lucky) making kernel.img smaller.  For
>    example, we currently make grub_prefix a static length string (could it
>    be dynamic? -> less space); then try to extract $root from it, since we
>    embedded it in the same place (if we had a scheme to specify it
>    separately -> less code to parse it).

I think it can be dynamic, we can store it right after the modules.
Although the area is compressed, so we can't use grub-editenv to
change it easily.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]