[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Tidy up 'make' output

From: Colin D Bennett
Subject: Re: [PATCH] Tidy up 'make' output
Date: Tue, 17 Jun 2008 15:31:54 -0700

On Tue, 17 Jun 2008 22:37:10 +0200
Robert Millan <address@hidden> wrote:

> On Tue, Jun 17, 2008 at 10:44:48AM -0700, Colin D Bennett wrote:
> > with output that, in my opinion, makes it easier to see warnings and
> > errors:
> > 
> >   COMPILE         ../util/getroot.c
> >   COMPILE         ../kern/device.c
> >   ../kern/device.c: In function 'grub_device_iterate':
> >   ../kern/device.c:84: warning: generating trampoline in object
> >   (requires executable stack)
> >   ../kern/device.c:84: warning: generating trampoline in object
> >   (requires executable stack)
> >   COMPILE         ../kern/disk.c 
> >   COMPILE         ../kern/err.c
> >   COMPILE         ../kern/misc.c
> I don't like the idea of hiding information this way.  If the goal is
> to catch warnings, I think -Werror can do a much better job (and
> catching errors shouldn't be a problem unless you're using make -j or
> -k).

What about all the "trampoline" and strict-aliasing warnings (there must
be hundreds of them)?  I'm all for warning-free code, but if we try to
use -Werror, the code won't even begin to compile in the current state.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]