[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Failure to embed core.img is fatal now

From: Pavel Roskin
Subject: Re: Failure to embed core.img is fatal now
Date: Sun, 29 Jun 2008 12:20:22 -0400
User-agent: Internet Messaging Program (IMP) H3 (4.1.4)

Quoting Robert Millan <address@hidden>:

On Thu, Jun 26, 2008 at 12:54:54PM -0400, Pavel Roskin wrote:
+             dos_part = grub_cpu_to_le32 (root_dev->disk->partition->index);
+             bsd_part = grub_cpu_to_le32 (-1);
   grub_util_info ("dos partition is %d, bsd partition is %d",
-                 grub_le_to_cpu32 (*install_dos_part),
-                 grub_le_to_cpu32 (*install_bsd_part));
+                 grub_le_to_cpu32 (dos_part), grub_le_to_cpu32 (bsd_part));

You're doing endian conversion twice.

Nice catch, thanks! Anyway, the code is PC specific, so the conversions do nothing.

Pavel Roskin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]