[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH] Sector 2 of non-embedded core.img: write early or patch
Re: [RFC PATCH] Sector 2 of non-embedded core.img: write early or patch later?
Mon, 30 Jun 2008 18:43:59 -0400
On Sat, 2008-06-28 at 12:58 +0800, Bean wrote:
> On Sat, Jun 28, 2008 at 5:24 AM, Pavel Roskin <address@hidden> wrote:
> > I tend to prefer the later ("write early") approach, but I'd like to see
> > some feedback before I commit it.
> The problem of write early is that it changes the target image before
> verification is made, so if verification fails, the change remains.
> This is generally not a good practice, we should not touch core.img if
> it can't be embedded successfully.
OK, that's a good argument. Actually, if grub-install is used, core.img
would have been rewritten already. Anyway, core.img is a file we want
to touch as little as possible, considering that it can already be used.
I'm applying the "patch-later" patch with some simplifications and