[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Enable writing to ATA devices, fix several bugs

From: Marco Gerards
Subject: Re: [PATCH] Enable writing to ATA devices, fix several bugs
Date: Thu, 03 Jul 2008 20:27:15 +0200
User-agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)

Pavel Roskin <address@hidden> writes:

> We have save_env now, so we can use the write capability.  This also
> fixes the last compiler warning in GRUB.


> Sorry, Marco, please ignore the previous message, as it didn't get to
> the list.

The more patches I get, the better ;-)

> ChangeLog:
>       * disk/ata.c (grub_ata_pio_write): Check status before writing,
>       like we do in grub_ata_pio_read().
>       (grub_ata_readwrite): Always write individual sectors.  Fix the
>       sector count for the remainder.


>       (grub_ata_write): Enable writing to ATA devices.  Correctly
>       report error for ATAPI devices.

Great!  Did you test this?

If you can fix Roberts comment, it would be great!  Can you commit it


reply via email to

[Prev in Thread] Current Thread [Next in Thread]