[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Eliminating grub_size_t

From: Marco Gerards
Subject: Re: Eliminating grub_size_t
Date: Thu, 03 Jul 2008 20:56:52 +0200
User-agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)

Pavel Roskin <address@hidden> writes:

> On Thu, 2008-07-03 at 20:02 +0200, Marco Gerards wrote:
>> > I know what it is.  I believe int should be as good as size_t for most
>> > purposes is we are not working with very large structures or read
>> > gigabytes of data from files at once.
>> Perhaps, but it doesn't hurt either.  I think it is a good thing to
>> have a type such that it is clear what kind of variable is used.
> I mean, we can have the type, but make it 32-bit on all systems.
> Anyway, the warnings have been fixed.  In some cases, grub_size_t was
> used for offsets, which is wrong because we want to support large files
> on 32-bit systems.
> I think I'll try to make grub_size_t 32-bit everywhere and see if it's
> going to make any difference or help discover some issues.

Please don't.  I'd rather stick to integers, such change will only
slow down GRUB with no gain.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]