[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] disk/fs_uuid.c

From: Marco Gerards
Subject: Re: [PATCH] disk/fs_uuid.c
Date: Thu, 03 Jul 2008 21:05:54 +0200
User-agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)

Robert Millan <address@hidden> writes:

> This disk driver allows access to partitions that contain a filesystem with
> known UUID via "(UUID=xxxxxxx)" syntax.
> The iterator is unimplemented on purpose, because it makes the code smaller
> and it isn't useful to waste time inspecting the same devices twice while
> scanning for LVM / whatsoever.
> Also note that as it currently stands it is highly inefficient.  I can't
> understand why;  new UUIDs are searched everytime on each open() call, but
> this shouldn't be much of an issue since we have a disk cache in kernel to
> make that efficient.  At least, it isn't e.g. for grub_fs_probe() which is
> called multiple times.
> Even with this efficiency problem, since it doesn't interfere with anything
> else I'm inclined to commit it, if nobody objects.

Why didn't you just extend the search command?  I think that would be


reply via email to

[Prev in Thread] Current Thread [Next in Thread]