[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: grub-probe detects ext4 wronly as ext2

From: Javier Martín
Subject: Re: grub-probe detects ext4 wronly as ext2
Date: Fri, 04 Jul 2008 16:45:02 +0200

El vie, 04-07-2008 a las 16:21 +0200, Robert Millan escribió:
> If you wish to send a patch for the user environment check you proposed,
> could send it separately?  I'm inclined to commit the flag check, but not
> the environment stuff.
Ok, here is the old version of the patch without the user override
thingy (and the extents reference removed).

> Afterwards if you like we could discuss about whether we should be
> "best-effort" in real GRUB or not.  It's really not such a big deal,
> as long as we don't end up cluttering the user interface because of it.
By the way, it's true that UI should be carefully thought of and we
should exercise great care not to end like GRUB Legacy with its quirks
and such, but... this is a bootloader, not Mac OS X! Even though it
should have simple paths, it's supposed to be complex (within reason)

> On Fri, Jul 04, 2008 at 03:32:43AM +0200, Javier Martín wrote:
> > -  grub_error (GRUB_ERR_BAD_FS, "not an ext2 filesystem");
> > +  grub_error (GRUB_ERR_BAD_FS, "not an ext2 filesystem, or incompatible"
> > +                               "features enabled (extents, etc.)");
> I would avoid referring explicitly to the features involved, because it
> means the message will end up being obsolete when extents are supported
> (and we will likely forget to update it).
True - parenthesized part removed form the patch.

By the way, I'm already using SVN (and thus svn diff) for this patch. Is
that right? Was the migration completed already?

Attachment: ext4_unrecognized.patch
Description: Text Data

Attachment: signature.asc
Description: Esta parte del mensaje está firmada digitalmente

reply via email to

[Prev in Thread] Current Thread [Next in Thread]