[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC] TSC patch v2

From: Vesa Jääskeläinen
Subject: Re: [RFC] TSC patch v2
Date: Fri, 04 Jul 2008 22:49:59 +0300
User-agent: Thunderbird (Windows/20080421)

Hi Colin,

Colin D Bennett wrote:
Here is an updated version of the TSC patch.

I addressed the issues in your comments with the exception of
supporting x86 CPUs that don't have a TSC (386 and 486).

I eliminated the grub_time_init() function and the call to it in
grub_main() in favor of having grub_machine_init() simply call
grub_tsc_calibrate().  The i386-pc and i386-efi platforms use the TSC.

Please still use grub_time_init(). Detect TSC, if it is there calibrate and adapt for it. If it is not there, use RTC.

grub_time_init() is just more clearer term than tsc. At least for people that are not familiar with it. in grub_time_init() you can have anything then. And people that are not interested on time stuff do not need to bother their heads about it. Also modifying logic afterwards do not change other parts and it will be less error prone.

Vesa Jääskeläinen

reply via email to

[Prev in Thread] Current Thread [Next in Thread]