[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: a bug in read

From: Pavel Roskin
Subject: Re: a bug in read
Date: Fri, 11 Jul 2008 14:23:17 -0400

On Wed, 2008-07-09 at 19:56 +0200, Javier Martín wrote:
> Couldn't this have been worked around changing while to do-while and
> refactoring the loop instead of creating a new variable, whose
> handling takes space? I'm not sure it can be done because I'm on
> vacation and reading mail through dialup access, but it might be worth
> a try.

A new variable was useful anyway to strip the final newline, but
changing the loop logic made the code more readable.  It's a standard
case where the exit condition occurs in the middle of the block, not in
the beginning or in the end.

The patch has been applied.

Pavel Roskin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]