Re: [PATCH] Abort grub-install if prefix cannot be determined

[Pavel Roskin]

On Fri, 2008-07-25 at 22:37 +0200, Robert Millan wrote:
> On Thu, Jul 24, 2008 at 07:39:24AM +0200, Christian Franke wrote:
> > grub-install does not check error return from 
> > make_system_path_relative_to_its_root() fails.
> > 
> > BTW: Unlike the other scripts, grub-install does not 'set -e'. Is this 
> > intentional or historic ?-)
> 
> I think it's historic.  Wouldn't mind moving it to 'set -e' (although one
> would have to check which grub-probe calls are allowed to fail).  What
> do others think?

I agree with you.  It's better to add explicit "|| :" to a few commands
that can fail than to allow every command to fail.

-- 
Regards,
Pavel Roskin