[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] update-grub for Cygwin

From: Christian Franke
Subject: Re: [PATCH] update-grub for Cygwin
Date: Tue, 29 Jul 2008 17:40:14 +0200
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv: Gecko/20071128 SeaMonkey/1.1.7

Robert Millan wrote:
On Sun, Jul 27, 2008 at 02:09:02AM -0400, Pavel Roskin wrote:
On Sat, 2008-07-26 at 14:53 +0200, Christian Franke wrote:
Robert Millan wrote:
On Thu, Jul 24, 2008 at 10:19:17PM +0200, Christian Franke wrote:
+  case "`uname 2>/dev/null`" in
+    CYGWIN*)
Could this be done at build time instead? (when generating update-grub

Yes, of course. Some alternatives:

I think it's better to have the check at the run time than any of those
alternatives.  If we have many OS specific checks, then we can think how
to leave the relevant ones.  At this point, it's probably not worth the

Ok I don't mind.  It was just a suggestion.

For now, I committed the original version with the run time check.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]