[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Correcting GRUB_CONSOLE_KEY_NPAGE/PPAGE
From: |
Robert Millan |
Subject: |
Re: [PATCH] Correcting GRUB_CONSOLE_KEY_NPAGE/PPAGE |
Date: |
Sat, 30 Aug 2008 13:50:05 +0200 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
On Sun, Aug 24, 2008 at 04:29:44PM +0200, Carles Pina i Estany wrote:
>
> Hi,
>
> I was just thinking now...
>
> On Aug/24/2008, Carles Pina i Estany wrote:
>
> > * include/grub/powerpc/ieee1275/console.h (GRUB_TERM_NPAGE):
> > Changed to 0x5100.
> > (GRUB_TERM_PPAGE): Changed to 0x4900.
> >
> > * include/grub/sparc64/ieee1275/console.h: Likewise.
> >
> > * include/grub/i386/pc/console.h: Likewise.
> >
> > * include/grub/efi/console.h: Likewise.
>
> I was just thinking... is there any reason that we have the same macros
> in 4 different files?
This would need to be checked carefully, but a quick peek at
GRUB_CONSOLE_KEY_LEFT:
./kern/i386/pc/startup.S: .word GRUB_CONSOLE_KEY_LEFT, GRUB_TERM_LEFT
./include/grub/i386/pc/console.h:#define GRUB_CONSOLE_KEY_LEFT 0x4B00
./include/grub/efi/console.h:#define GRUB_CONSOLE_KEY_LEFT 0x4B00
./include/grub/powerpc/ieee1275/console.h:#define GRUB_CONSOLE_KEY_LEFT
0x4B00
./include/grub/sparc64/ieee1275/console.h:#define GRUB_CONSOLE_KEY_LEFT
0x4B00
seems to indicate these macros are part of the BIOS console interface,
and therefore only used on i386-pc.
If you can confirm this, I'd recommend just removing them from the other
console.h files.
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."