Re: [PATCH] fix disk->id abuse

[Robert Millan]

On Tue, Sep 02, 2008 at 03:55:18PM +0200, Marco Gerards wrote:
> 
> [...]
> 
> >> We could write a macro for ID comparison that would compare both the
> >> "driver ID" (disk->dev->id) and "device ID" (disk->id).  In this case,
> >> we can omit disk->id initialization in the drivers supporting only one
> >> device (e.g. memdisk) and only leave it where it's indeed needed for
> >> identifying separate devices, thus removing potentially confusing code.
> >
> > Sounds fine, although what worries me most if the current usage of 'id' in
> > scsi.c, which can lead to collision already.
> >
> > I assume using LUNs is a proper solution for that one?
> 
> No, it is not.  I think I already said so on IRC?

If you did, I must have missed it.  In any case, what can we use instead of
that?

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."