grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Move cpuid.mod to conf/i386.rmk (Re: RFC: conf/i386.rmk)


From: Robert Millan
Subject: [PATCH] Move cpuid.mod to conf/i386.rmk (Re: RFC: conf/i386.rmk)
Date: Fri, 5 Sep 2008 12:54:03 +0200
User-agent: Mutt/1.5.13 (2006-08-11)

On Tue, Aug 05, 2008 at 05:08:29PM -0400, Pavel Roskin wrote:
> On Tue, 2008-08-05 at 22:07 +0200, Robert Millan wrote:
> > On Tue, Aug 05, 2008 at 12:49:46PM -0400, Pavel Roskin wrote:
> > > On Tue, 2008-08-05 at 09:58 +0300, Vesa Jääskeläinen wrote:
> > > 
> > > > > I tried moving more stuff to common.rmk many times but gave up every
> > > > > time.  One of the reasons is that the sparc64 support is very
> > > > > out-of-date and doesn't use common.rmk at all.  I cannot even test it
> > > > > (well, I haven't tries hard).
> > > > 
> > > > If sparc64 support is out of date and the maintainer is nowhere to be 
> > > > seen then I think you can put that support to graveyard until someone 
> > > > comes up to update it. Putting all common stuff to every platform to 
> > > > common.rmk is a good way and the only way (in my opinion) to go forward.
> > > 
> > > OK, then there is an issue that it doesn't work if done naively.
> > 
> > What is the problem exactly?
> 
> Take all text in conf/i386-pc.rmk from "For grub-emu" to "Scripts" and
> move it to the end of conf/common.rmk.  Run autogen.sh, configure
> --enable-grub-emu and make.  You'll get:
> 
> make: *** No rule to make target `grub-emu', needed by `all-local'.
> Stop.

Okay then.  Since it appears this kind of changes are delicate, I propose
doing them granularly.

Here's my first patch, that moves cpuid.mod and sets the base for moving more
stuff later (I've tested the resulting cpuid.mod is built correctly).

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."

Attachment: i386.diff
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]