[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] fseek -> fseeko

From: Pavel Roskin
Subject: Re: [PATCH] fseek -> fseeko
Date: Tue, 13 Jan 2009 19:23:30 -0500

On Wed, 2009-01-14 at 00:10 +0100, Carles Pina i Estany wrote:
> Hello,
> I see in the ChangeLog that fseek() has been replaced by fseeko(). But
> there still is one fseek in Grub2 that has not been changed.

It's because grub-editenv.c appeared after the commit that eliminated

>  As far as I
> can understand by "mistake" (should not affect anything but ChangeLog
> says, about fseek, for example:
> -------
>         * util/grub-fstest.c (cmd_cmp): Use fseeko(), not fseek().  The
>         later is obsolete, potentially dangerous and sets a bad example.
> -------
> So better to replace it?

It doesn't really matter when the offset is 0, but let's replace it to
avoid further questions.

> ChangeLog:
> ----------
> 2008-14-01  Carles Pina i Estany <address@hidden>
>       * util/grub-editenv.c (main): Use fseeko(), not fseek().

The year is placed first to make the format unambiguous.  Also, string
comparison would work for dates.  But only if the month follows the

> Could someone commit it?

Committed, a day before you posted the patch :-)

Actually, you didn't post the patch.  You posted the whole file.  Be

Pavel Roskin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]