grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] make partition active


From: Bean
Subject: Re: [PATCH] make partition active
Date: Mon, 2 Mar 2009 11:52:13 +0800

On Mon, Mar 2, 2009 at 5:20 AM, phcoder <address@hidden> wrote:
> Hello
>>>
>>> It's also possible to write a wrapper
>>> parttool hd0,1 boot+
>>>
>>> Which chooses the correct tool and launches it (a tool can be easily
>>> registered as a pair of partition style name and a function). In this
>>> case
>>> we wouldn't even need separate command for different partition style. We
>>> have however to find a way to list all available flags in
>>>
>>> help parttool
>>
>> Hi,
>>
>> The patch looks fine to me, except for perhaps the name. activate
>> doesn't seems to suggest its function. Frankly, makeactive doesn't
>> make much sense as well, but at least it's already widely used in grub
>> legacy, old user could easily guess its function by name.
>>
> Then we could use parttool syntax. Then parttype can be implemented like
> grub> parttool hd0,1 type=7
> makeactive like:
> grub> parttool hd0,1 boot+
> And it can even be done by one command
> grub> parttool hd0,1 boot+ type=7
>
> Thank you for your attention to my patches

Hi,

In that case, you might want to use options, which save you the
trouble of parsing parameters yourself, for example:

parttool [--boot] [--type N] partition

-- 
Bean




reply via email to

[Prev in Thread] Current Thread [Next in Thread]