grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] FAT, UFS and mtime


From: Robert Millan
Subject: Re: [PATCH] FAT, UFS and mtime
Date: Fri, 13 Mar 2009 20:10:30 +0100
User-agent: Mutt/1.5.18 (2008-05-17)

On Sun, Mar 01, 2009 at 05:25:10PM +0100, phcoder wrote:
> Hello all. It seems that gcc has trouble with -m32 when structure is  
> passed as argument. So I replaced that part by a pointer. Also I made  
> some improvements to ufs code to support solaris branch of ufs. I tested  
> it also with freebsd and netbsd's branch and it works fine on it too.
> As my 3 FS patches: mtime, FAT and UFS are interdependent I submit a  
> patch with all 3 features. If it's really necessary I can split them but  
> it requires a lot of unnecessary work

Please do.  It is definitely confusing to review patches that merge
unrelated things.

Also, please don't include the changelog entry in your patch, since those
break too easily.  Just paste it at the top of your mail.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."




reply via email to

[Prev in Thread] Current Thread [Next in Thread]