grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] linux/gfxterm integration


From: Robert Millan
Subject: Re: [PATCH] linux/gfxterm integration
Date: Fri, 13 Mar 2009 20:44:47 +0100
User-agent: Mutt/1.5.18 (2008-05-17)

On Sun, Mar 08, 2009 at 03:35:30PM +0200, Vesa Jääskeläinen wrote:
> Robert Millan wrote:
> >> Note: As the comment in grub/video.h says, struct grub_video_render_target
> >> didn't really want to be moved.  My code only needs to access it to find
> >> the framebuffer address.  Perhaps it'd be better to move this information
> >> elsewhere?  Or split it in a separate structure / getter?
> > 
> > Any comments on my question about struct grub_video_render_target ?
> 
> Don't like em... Let me think it a bit.

This new patch avoids the problem by accessing struct grub_video_render_target
from its current location.

When we have more than one video backend, and a clear idea on which parts are
generic and which are backend-specific, we could readjust.  For now this makes
VBE happy.

Thoughts?

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."

Attachment: linux_gfxterm.diff
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]