grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Split of the normal mode


From: phcoder
Subject: Re: [PATCH] Split of the normal mode
Date: Sun, 29 Mar 2009 13:33:48 +0200
User-agent: Thunderbird 2.0.0.21 (X11/20090318)

I agree when it's about big changes. I wouldalso not commit anything what isn't quite tested or may break something. But when one-line bugfixes stay uncommited during 2-3 weaks it's something that isn't quite ok. Also if noone comments a relatively small patch in 1-2 weeks I think we should consider that everybody is happy with the patch and it should be commited. However somehow on this project it's not the same rules for everyone.
Vesa Jääskeläinen wrote:
Here I must comment that in some cases it is favorable to do it this
way. I personally will only commit changes that I am happy to live with.
Even if you are developer with SVN commit rights it is in some cases
good idea to have general review of the patch... but there has been some
lack of the time from people to review them (and it does not cross
everyones interest zones, thus get attention to the patch).

phcoder wrote:
I'm actually quite unhappy with the grub's authority in general. Some
people can commit their patches after a week of no replies while others
like me have to wait that someone has time to review their patches in
depth. I already have a collection of patches that are not commited, not
because someone objects against them but just because nobody qualified
enough has time to review and commit it. All this despite having already
signed copyright assignment which because of slowness of FSF took more
time than it should. From developer viewpoint it's very frustrating
experience. If I wasn't so motivated as I am I would have already given
up. IMO opinion if we want people coding for grub2 this has to be
changed. But now you come and say you want to revert some patches just
because they seem useless to you or rewrite some code just because you
find it ugly or because it has a minor bug which could be easily fixed
without rewriting. IMO this can easily drive developers to fork or leave
project altogether. And additionally your energy would be much better
spent in writing new stuff and making/reviewing design propositions than
rewriting chunks of already working code.
Sorry for being somewhat rude but I really find it frustrating this
coder-unfriendliness
In brief, I take back the leadership of this project for general
directions. For some subsystems (e.g. the coreboot support), I
continue leaving the responsibility to those who know better or are
more active. Once the current code is reviewed and fixed (at some
degree), I will make a new release.

Any objection?

Regards,
Okuji




_______________________________________________
Grub-devel mailing list
address@hidden
http://lists.gnu.org/mailman/listinfo/grub-devel


--

Regards
Vladimir 'phcoder' Serbinenko




reply via email to

[Prev in Thread] Current Thread [Next in Thread]