grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] parttool


From: phcoder
Subject: Re: [PATCH] parttool
Date: Mon, 06 Apr 2009 11:52:38 +0200
User-agent: Thunderbird 2.0.0.21 (X11/20090318)

Fixed & commited. My next patch will be to add automatic module loading in parttool
Yoshinori K. Okuji wrote:
On Saturday 04 April 2009 18:22:39 phcoder wrote:
Can someone review this patch?

Only some style should be corrected. For example:

+#ifndef GRUB_UTIL
+  if (!parts)
+    grub_dl_unref (mymod);
+#endif

Our convention is to put a space between "!" and "parts", so this should be:

+#ifndef GRUB_UTIL
+  if (! parts)
+    grub_dl_unref (mymod);
+#endif

Also, the ChangeLog should state what variables are affected explicitly. For example:

* conf/common.rmk: Added parttool.mod and pcpart.mod

Instead, you should say:

* conf/common.rmk (parttool_mod_SOURCES): New variable.
(parttool_mod_CFLAGS): Likewise.
(parttool_mod_LDFLAGS): Likewise.
...and so on...

The code itself looks good, so you can check it in, once you correct the styles.

Regards,
Okuji


_______________________________________________
Grub-devel mailing list
address@hidden
http://lists.gnu.org/mailman/listinfo/grub-devel


--

Regards
Vladimir 'phcoder' Serbinenko




reply via email to

[Prev in Thread] Current Thread [Next in Thread]