grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Video mode fixes in linux loader


From: phcoder
Subject: Re: [PATCH] Video mode fixes in linux loader
Date: Tue, 07 Apr 2009 09:31:57 +0200
User-agent: Thunderbird 2.0.0.21 (X11/20090318)

Does it actually work? I don't see the code which either handles GRUB_LINUX_VID_MODE_ASK or passes it to the kernel. Also it looks like vga= parameter is parsed by grub and grub passes only video mode values as resolution and color depth. Wouldn't it be better to move to a more modern video mode specification method? As gfxpayload variable previously discussed on that list
Pavel Roskin wrote:
On Tue, 2009-04-07 at 09:31 +0900, Yoshinori K. Okuji wrote:
+  free_pages();
Please insert a space before the parenthesis.

Done.

This is not due to you, but the comment above is not synchronized with the code apparently. Can you fix it?

Fixed and committed.



--

Regards
Vladimir 'phcoder' Serbinenko




reply via email to

[Prev in Thread] Current Thread [Next in Thread]