[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Video mode fixes in linux loader

From: Pavel Roskin
Subject: Re: [PATCH] Video mode fixes in linux loader
Date: Tue, 07 Apr 2009 18:04:18 -0400

On Tue, 2009-04-07 at 09:31 +0200, phcoder wrote:
> Does it actually work?

No.  But at least it loads the kernel.

>  I don't see the code which either handles 
> GRUB_LINUX_VID_MODE_ASK or passes it to the kernel.

We could set params->vid_mode, but the mode setting in the kernel is
done in the 16-bit code that we don't use.

>  Also it looks like 
> vga= parameter is parsed by grub and grub passes only video mode values 
> as resolution and color depth. Wouldn't it be better to move to a more 
> modern video mode specification method? As gfxpayload variable 
> previously discussed on that list

OK, I just fixed the issue that was annoying me.  Being a PC user, I
don't really care about the graphical boot.

After touching that code, I believe the 32-bit Linux loader should not
parse the vga option at all.  It's irrelevant.

Instead, the loader should either load the kernel in the current mode
(text of gfxterm) or it should restore the text mode.  I believe not all
kernels can start in graphical mode, so using the graphical mode should
be enabled explicitly by some option.

If the platform doesn't have text mode, then obviously the current mode
should be used.

I don't see any strong need to use different video modes in GRUB and in
the kernel.  If somebody needs that, the mode in GRUB can be changed
before loading the kernel.  Also, a kernel video driver can change the
mode upon initialization using driver-specific parameters.

GRUB could implement video mode handling compatible with the Linux
internal bootloader, including "vga=ask", but I'm not sure we need it.

Pavel Roskin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]