|
From: | phcoder |
Subject: | Re: [PATCH] add clear screen command |
Date: | Thu, 09 Apr 2009 15:44:10 +0200 |
User-agent: | Thunderbird 2.0.0.21 (X11/20090318) |
Carlos Roberto do Nascimento Costa wrote:
Hello phcoder. thank you for reviewing this patch.
You're welcome
With your patch the created elf contains much more overhead then code. While it isn't really a problem it's still a thing about which some thinking is neededphcoder wrote:Perhaps putting it into normal.mod instead of separate module is a good ideaWhen I did this patch, I was thinking: clear is a command like ls, lspci, reboot, sleep, suspend, halt, exit, etc... so, clear needs to be at commands/ dir and follows the same ideas behind other commands. Is there any reason to not follows this idea?
Best regards,
-- Regards Vladimir 'phcoder' Serbinenko
[Prev in Thread] | Current Thread | [Next in Thread] |