[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Split of normal mode (version 2)

From: Yoshinori K. Okuji
Subject: Re: [PATCH] Split of normal mode (version 2)
Date: Fri, 10 Apr 2009 08:49:57 +0900
User-agent: KMail/1.9.10

On Tuesday 07 April 2009 01:39:23 Bean wrote:
> Hi,
> This is another update of the patch.
> 1, Now completion.c is in menu.mod, and menu_viewer.c is in misc.mod,
> the reason for the switch is to allow configfile to depend on misc.mod
> only.

I think the name "misc.mod" is ugly. Can you think about a better name?

> 2, Auto generate handler.lst file, which contain module information
> for handlers. normal.mod uses it to register commands to set active
> handler, for example:
> menu_viewer.text
> terminal_output.gfxterm


> 3, configfile now support an optional parameter to specify the script
> engine, for example:
> configfile /aa.cfg sh
> When configfile returns, the script engine would be restored to the
> previous value. This is useful for switching script engine. For
> example, you can parse a file in another language, then switch back to
> sh for the rest of grub.cfg.

I object to the syntax, but not to the idea. "configfile" is GRUB-specific, so 
it might be acceptable. But IIRC the underlying function is shared 
with "source", right? In Bourne Shell, "source FILE ARG" means that the file 
FILE is executed with a positional argument ARG. So it is not intuitive to 
specify a parser this way.

I proposed using a shebang some days ago. Was it so bad?

> 4, normal.mod set the default parser and menu viewer before parsing
> grub.cfg:
> menu_viewer.text


reply via email to

[Prev in Thread] Current Thread [Next in Thread]