[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Preboot support

From: Yoshinori K. Okuji
Subject: Re: [PATCH] Preboot support
Date: Sat, 11 Apr 2009 19:16:05 +0900
User-agent: KMail/1.9.10

On Saturday 11 April 2009 08:48:07 phcoder wrote:
> Hello, here is the preboot hooks support. Apply on top of my bootmove
> patch. They are very useful for patches like sendkey (my old patch that
> I'll rediff), badram, acpi (2 patches in separate threads) or drivemap

Some comments about the design.

- register/unregister is more appropriate than add/remove.

- preboot is ambigous. preboot_hook is better.

- Using an int value for the priority is quetionable. Very often, this style 
of priority system leads to chaos, because everyone picks up arbitrary 
numbers randomly. I prefer to define enums with a careful analysis.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]