[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Build system improvement

From: Colin D Bennett
Subject: Re: [PATCH] Build system improvement
Date: Sat, 11 Apr 2009 08:29:59 -0700
User-agent: KMail/1.11.2 (Linux/2.6.28-11-generic; KDE/4.2.2; x86_64; ; )

Yoshinori K. Okuji wrote on Saturday 11 April 2009:
> On Saturday 11 April 2009 08:25:50 phcoder wrote:
> > I don't see any stoppers to merge this patch
> Personally, I don't like this so much. Is it so useful?

Absolutely.  I find it tedious to scroll back through thousands of lines of 
text full of gcc command lines with lots of options etc. to find the actual 
warnings that could indicate (and usually do!) that I made an error in my 
code.  When all the lines generally have a concise and uniform appearance, it 
is visually easy to scan for warnings, compared to now where the lines printed 
are very long and often wrap onto multiple lines, obscuring warnings.

If we could build with -Werror, then it wouldn't be so hard to find the 
warnings since the build would abort...

I think there is only one warning (the “trampoline” warning) that we want to 
ignore.  All others can and should be fixed (and they may be already).


> > Javier Martín wrote:
> > > This patch modifies several files in the build system (mainly
> > > common.rmk and genmk.rb) to reduce the general verbosity of the build
> > > process to a manageable, semi-informative level. Thus, what currently
> > > appears as "gcc" calls, several lines long each is turned into lines
> > > like:
> > >
> > > [M xfs.mod] COMPILE ../src/fs/xfs.c ->
> > > xfs_mod-fs_xfs.o
> > > [M xfs.mod] LINK xfs_mod-fs_xfs.o ->
> > > pre-xfs.o
> > > [M xfs.mod] Looking for EXPORTED SYMBOL definitions: pre-xfs.o
> > >
> > > And so on. The change also makes warning-hunting marginally easier,
> > > though not by much since the patch intentionally shows a line for
> > > nearly every process that did so previously. This behavior could be
> > > simplified further if needed - this post is more of an RFC than
> > > anything else. Also, it is by no means thorough or complete - only the
> > > most common processes have been addressed - as I'm a bit busy with
> > > exams.
> > >
> > > The patch makes the new behavior the default one, so a new make-time
> > > option is added: V (for "verbose"), which must have the value 1 in
> > > order to get the behavior, as in "make V=1"

Attachment: signature.asc
Description: This is a digitally signed message part.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]