[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH]: grub: Fix ofdisk disk cache corruption.

From: David Miller
Subject: Re: [PATCH]: grub: Fix ofdisk disk cache corruption.
Date: Sun, 12 Apr 2009 18:04:44 -0700 (PDT)

From: Pavel Roskin <address@hidden>
Date: Sun, 12 Apr 2009 17:01:07 -0400

> It's not just about distribution properties.  My impression is that your
> code misuses hashes as indices in a table.  Let's make the hash 32-bit.
> That would make it harder to misuse.

They aren't indices in the traditional sense, they are simply
unique ID's just like the filesystem UUIDs grub also supports.

Their only purpose it to indicate uniqueness, nothing more.

Since we have to allocate in-memory objects to remember the
previously used paths anyways, it is just the most convenient
thing to do to use the address of the object.

Other disk drivers do this too, I'm not inventing anything
nor doing anything strange here.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]