[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH]: grub: Allow to control objcopy '-B' argument from foo.rmk f
Re: [PATCH]: grub: Allow to control objcopy '-B' argument from foo.rmk files.
Sun, 12 Apr 2009 23:38:50 -0700 (PDT)
From: David Miller <address@hidden>
Date: Sat, 11 Apr 2009 04:46:44 -0700 (PDT)
> From: "Yoshinori K. Okuji" <address@hidden>
> Date: Sat, 11 Apr 2009 19:23:23 +0900
>> On Saturday 11 April 2009 17:08:31 David Miller wrote:
>>> This patch allows a platform to specify the image file output
>>> format, it also adds the --strip-unneeded option to the objcopy
>>> invocation as well.
>> IIRC, --strip-unneeded was dangerous.
> I would like to have information about this :-)
>>> I've left the i386-pc.mk portion of this patch out of the posting,
>>> but rest assured I will check that part in once this gets an ACK :-)
>> I don't like "IMG_FMT". How about "FORMAT"? If too ambiguous,
>> I prefer not to use uncommon abbrevs.
> That's fine with me, I'll update the patch once the strip issue
> is resolved.
In the name of progress I've commited these changes, with the
recommended use of *_FORMAT instead of *_IMG_FMT.
If this stripping of the resulting image is found to cause a
real problem, we can revert that part of the change and work
out a solution.