[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: grub: Eliminate recursive reads of the same device in grub_dl_load_f
Re: grub: Eliminate recursive reads of the same device in grub_dl_load_file().
Mon, 13 Apr 2009 16:05:41 -0700 (PDT)
From: David Miller <address@hidden>
Date: Sun, 12 Apr 2009 23:56:11 -0700 (PDT)
> Openfirmware block device drivers do not allow for multiple concurrent
> opens of the same device. It simply does not work.
> Fortunately grub doesn't actually need to do this, it just happens
> to do so. Here is the fix for the case of module dependency handling.
> The other case that hits this problem is in the FS_UUID support code.
> I have patches later which will fix that case too, but that one is a
> little more involved as we have to fix some bugs in the the ieee1275
> devalias iterator first (for one, it doesn't stop when the callback
> returns non-zero as every other iterator in grub2 does).
> 2009-04-12 David S. Miller <address@hidden>
> * kern/dl.c (grub_dl_load_file): Close file immediately when
> we are done using it.
I've committed this change as well.