[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] parttool

From: Vladimir Serbinenko
Subject: Re: [PATCH] parttool
Date: Sat, 25 Apr 2009 14:21:06 +0200


On Fri, Apr 17, 2009 at 1:12 PM, phcoder <address@hidden> wrote:
Thank you for the testing

Please remove one space after "list".

I've tested the command quickly.  A few notes.

We need a command to list the partition table, as "ls" doesn't show the
partition types.
The easiest way is to add an info string to partmap structure. This, however pollutes the partmap modules. The question is whether this info is useful enough to put it in partmap modules. I think no. I will code an additional command for this

It would be nice to have some feedback, e.g.
parttool (hd0,1) hidden+
Setting partition type to 0x92

"hidden" should work like "hidden+".

The "hidden" attribute doesn't apply to all partition types.  There is
no such thing as a hidden Linux swap partition.

I know, however I don't have an exhaustive list when this feature is useful, so I let the user to always use this feature and rely on his/her good sense

"parttool PARTITION" should work like "parttool PARTITION help" or maybe
it should give information about the partition.


Modules for the partition (like "pcpart") should be loaded automatically
for any commands including "help".  If that module is missing and cannot
be loaded, all commands should report is, not just "help".



Vladimir 'phcoder' Serbinenko

reply via email to

[Prev in Thread] Current Thread [Next in Thread]