[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Revision 2136 breaks two-disk configuarion
From: |
David Miller |
Subject: |
Re: Revision 2136 breaks two-disk configuarion |
Date: |
Tue, 28 Apr 2009 01:59:59 -0700 (PDT) |
From: Pavel Roskin <address@hidden>
Date: Mon, 27 Apr 2009 18:26:11 -0400
> On Sun, 2009-04-26 at 22:57 -0700, David Miller wrote:
>
>> grub_disk_open() isn't used, but a grub_device_open() does occur
>> during the iterator that has us find the FS_UUID device. This
>> happens search_fs_uuid().
>>
>> If we don't do this, we leave a device reference open and dangling.
>
> Then we should be using grub_device_close(). I've made a patch that
> keeps dev, not disk in the data field. Unfortunately, the problem
> persists. I could easily reproduce it on another machine by using a
> flash drive and qemu.
>
> It's entirely possible that the problem is elsewhere. But I have no
> experience debugging memory problems in GRUB, so it will take time
> before I find out.
>
> Here's the patch. It doesn't make the memory problem go away, but it
> makes the code nicer by using the same abstraction to open and close the
> disk.
>
I like this patch, please commit it.
- Revision 2136 breaks two-disk configuarion, Pavel Roskin, 2009/04/27
- Re: Revision 2136 breaks two-disk configuarion, David Miller, 2009/04/27
- Re: Revision 2136 breaks two-disk configuarion, Pavel Roskin, 2009/04/27
- [PATCH] Re: Revision 2136 breaks two-disk configuarion, Pavel Roskin, 2009/04/27
- Re: [PATCH] Re: Revision 2136 breaks two-disk configuarion, David Miller, 2009/04/27
- Re: [PATCH] Re: Revision 2136 breaks two-disk configuarion, Pavel Roskin, 2009/04/27
- Re: [PATCH] Re: Revision 2136 breaks two-disk configuarion, David Miller, 2009/04/28
- Re: [PATCH] Re: Revision 2136 breaks two-disk configuarion, Pavel Roskin, 2009/04/28
- Re: Revision 2136 breaks two-disk configuarion,
David Miller <=