[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Split #2: parser/reader separation

From: Vladimir 'phcoder' Serbinenko
Subject: Re: [PATCH] Split #2: parser/reader separation
Date: Sat, 2 May 2009 00:15:41 +0200

Patch looks fine for me. I think you can commit it
As for lua put the origin clearly and put the original copyright notice below grub's one. Tomorrow I'll do the same for freebsd64 patch and will merge it
Oh, I think it is quite compact already, have you got any suggestion
to reduce its size ?
The only possibility I've seen is to move grub_parser_execute out of kernel. However I don't  think it's practicable.

> Also it would be good to write the current parser in "grub>" prompt (not
> necessary for rescue prompt)

Good point.


Grub-devel mailing list

Vladimir 'phcoder' Serbinenko

Vladimir 'phcoder' Serbinenko

reply via email to

[Prev in Thread] Current Thread [Next in Thread]