grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Split #2: parser/reader separation


From: Bean
Subject: Re: [PATCH] Split #2: parser/reader separation
Date: Sun, 3 May 2009 03:50:14 +0800

Hi,

Thanks for the review, commit it now.

On Sat, May 2, 2009 at 6:15 AM, Vladimir 'phcoder' Serbinenko
<address@hidden> wrote:
> Patch looks fine for me. I think you can commit it
> As for lua put the origin clearly and put the original copyright notice
> below grub's one. Tomorrow I'll do the same for freebsd64 patch and will
> merge it
>>>
>>> Oh, I think it is quite compact already, have you got any suggestion
>>> to reduce its size ?
>
> The only possibility I've seen is to move grub_parser_execute out of kernel.
> However I don't  think it's practicable.
>>
>>>
>>> > Also it would be good to write the current parser in "grub>" prompt
>>> > (not
>>> > necessary for rescue prompt)
>>>
>>> Good point.
>>>
>>> --
>>> Bean
>>>
>>>
>>> _______________________________________________
>>> Grub-devel mailing list
>>> address@hidden
>>> http://lists.gnu.org/mailman/listinfo/grub-devel
>>
>>
>>
>> --
>> Regards
>> Vladimir 'phcoder' Serbinenko
>
>
>
> --
> Regards
> Vladimir 'phcoder' Serbinenko
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
>



-- 
Bean




reply via email to

[Prev in Thread] Current Thread [Next in Thread]