[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: status grub2 port of grub-legasy map command

From: Javier Martín
Subject: Re: status grub2 port of grub-legasy map command
Date: Sun, 03 May 2009 02:02:14 +0200

I am glad to inform that, with the new version of the mmap patch,
drivemap now boots all my hd1 installs of:
- Windows XP (Pro x64)
- ReactOS
- FreeDOS

I would suggest, however, that the return type of
grub_mmap_malign_and_register be changed to void* from char*, just like
the return type from malloc, because it's the meaningful data type to
indicate a pointer to generic memory _and_ it automatically casts to any
pointer type the caller uses (which is the reason it's used in malloc).

I've also added an "undo" function for install_int13_handler, as
partially required by the preboot hook interface, but I really have no
idea how to test it, so... is this implementation sensible? It just
restores the old int13 handler and frees the allocated memory.

-- Lazy, Oblivious, Recurrent Disaster -- Habbit

Attachment: drivemap.9.patch
Description: Text Data

Attachment: signature.asc
Description: Esto es una parte de mensaje firmado digitalmente

reply via email to

[Prev in Thread] Current Thread [Next in Thread]