[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] improve error messages in grub-setup

From: Pavel Roskin
Subject: Re: [PATCH] improve error messages in grub-setup
Date: Sun, 03 May 2009 00:35:08 -0400

On Sat, 2009-05-02 at 13:15 +0200, Robert Millan wrote:
> This patch improves error messages in grub-setup, and adds a few
> warnings when requested to install in odd layouts.
> Since there was no facility to emmit a warning that is always
> visible (regardless of verbosity), but doesn't abort execution,
> I added one (grub_util_warn ()).  Is everyone fine with using
> this interface?

I'm fine with the code, but the warnings are quite serious.  I think
grub-install should not proceed if there are any warnings unless there
is an option to ignore warnings (e.g. --ignore-warnings or --force).

Pavel Roskin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]