[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] improve error messages in grub-setup

From: Robert Millan
Subject: Re: [PATCH] improve error messages in grub-setup
Date: Sun, 3 May 2009 18:55:47 +0200
User-agent: Mutt/1.5.18 (2008-05-17)

On Sun, May 03, 2009 at 12:35:08AM -0400, Pavel Roskin wrote:
> On Sat, 2009-05-02 at 13:15 +0200, Robert Millan wrote:
> > This patch improves error messages in grub-setup, and adds a few
> > warnings when requested to install in odd layouts.
> > 
> > Since there was no facility to emmit a warning that is always
> > visible (regardless of verbosity), but doesn't abort execution,
> > I added one (grub_util_warn ()).  Is everyone fine with using
> > this interface?
> I'm fine with the code, but the warnings are quite serious.  I think
> grub-install should not proceed if there are any warnings unless there
> is an option to ignore warnings (e.g. --ignore-warnings or --force).

Agreed.  It's no harm to add --force for users who are stuck in such layouts.

Here's a new patch.

Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."

Attachment: embedding_warnings.diff
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]