[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] prevent duplicated entries due to symlinks

From: Pavel Roskin
Subject: Re: [PATCH] prevent duplicated entries due to symlinks
Date: Mon, 04 May 2009 00:32:19 -0400

On Fri, 2009-05-01 at 22:51 +0200, Andreas Born wrote:
> If there's both a symlink and a kernel at which the symlink is pointing 
> in the list of detected kernels of 10_linux, two entries are created for 
> actually the same kernel. This patch checks for this condition and only 
> uses the symlink (usually the wanted behaviour), in case the target of 
> the symlink doesn't exist, it uses neither.
> Furthermore there may be kernel images named e.g. /boot/vmlinuz, so to 
> detect those the patch doesn't require a hyphen in the kernel name.
> In this case the sed used to determine the kernel version, won't return 
> as expected an empty string. Therefore I replaced it by another one with 
> the wanted behaviour.
> If the kernel version can be empty we don't want to have a "GNU/Linux, 
> linux " menuentry. Accordingly this patch adds a check for empty kernel 
> version, so that only "GNU/Linux" will be displayed.

The result will be that we would have an entry without version instead
of an entry with a version.  That's hardly an improvement.  Can you give
an example where it would be useful?

> Finally there's quite a bunch of other names for initrds. This patch 
> adds support for initrd.gz and initrd.splash. Both initrd.img and 
> initrd.gz become or were yet supported with two different version 
> positions and without version at all. For initrd.splash this isn't 
> needed because it's not kernel version dependent.

Please specify where those names are used.  Can you give the
distribution name and version where such names are used?

What is initrd.splash?  Why does it need to be handled like initrd and
why is it always version independent?  Again, where is it used?

Pavel Roskin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]